git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/7] gitweb: Added parse_difftree_raw_line function for later use

From
Junio C Hamano <junkio@cox.net>
Date
Aug 17, 2006, 09:55 UTC
Message-ID
<7vfyfvsn2w.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11558064893592-git-send-email-jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 7 quoted lines
> +sub parse_difftree_raw_line {
> +	my $line = shift;
> +	my %res;
> +
> +	# ':100644 100644 03b218260e99b78c6df0ed378e59ed9205ccc96d 3b93d5e7cc7f7dd4ebed13a5cc1a4ad976fc94d8 M	ls-files.c'
> +	# ':100644 100644 7f9281985086971d3877aca27704f2aaf9c448ce bc190ebc71bbd923f2b728e505408f5e54bd073a M	rev-tree.c'
> +	if ($line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40}) ([0-9a-fA-F]{40}) (.)([0-9]{0,3})\t(.*)$/) {

We would probably want to say that status symbol is an uppercase alpha [A-Z]. Or maybe limit it to a non-whitespace letter (\S). Dot there to say "just any letter" looks wrong.

I would use "+" instead of hardcoding the length of mode strings (you have 6 there) and object name hash (ditto 40) but that is mostly style and a slight future proofing against us using longer hashes (not in our immediate future though).

Previous: Jakub NarebskiNext: Jakub Narebski
Message 10 of 12 in “A few gitweb cleanups and improvements”
  1. 0/7 A few gitweb cleanups and improvementsJakub Narebski, Aug 17, 2006
  2. 1/7 gitweb: Add support for per project git URLsJakub Narebski, Aug 17, 2006
  3. David RientjesAug 17, 2006
  4. 2/7 gitweb: Refactor printing commit messageJakub Narebski, Aug 17, 2006
  5. 3/7 gitweb: Fix typo in separation of git_difftree_bodyJakub Narebski, Aug 17, 2006
  6. 4/7 gitweb: Expand href() function to use key as param name for no mappingJakub Narebski, Aug 17, 2006
  7. Junio C HamanoAug 17, 2006
  8. Jakub NarebskiAug 17, 2006
  9. 5/7 gitweb: Added parse_difftree_raw_line function for later useJakub Narebski, Aug 17, 2006
  10. Junio C HamanoAug 17, 2006
  11. 6/7 gitweb: Sort query string parameters in href() functionJakub Narebski, Aug 17, 2006
  12. 7/7 gitweb: Uniquify version info output, add meta generator in page headerJakub Narebski, Aug 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.