Re: [PATCH/RFC 0/4] gitweb: ViewVC-like "tree_blame" view

From: Junio C Hamano <junkio@cox.net>
Date: Aug 31, 2006, 00:00 UTC
Message-ID: <7vfyfdg4fw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <ed55nu$62k$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 5 quoted lines

> At the below URL (links of course _won't_ work)
>   http://front.fuw.edu.pl/jnareb/tree_blame.html
> is output of  "tree_blame" view. One can sort by Date (age), Author, Mode
> and Filename. The date view was modelled after 'ls -l' view; the order of
> columns probably should be changed to match it more closely.

Just a quick impression.

 - "Mode" looks too wide for the information it conveys.  Path
   being a link already tells whether it is a tree, so the only
   information you would need is a bit and half (regular file,
   executable regular file, or symbolic link).

 - Spelling out Date in human readable form is fine but I suspect
   it would be nicer if it used YYYY-MM-DD / MM-DD HH:MM

 - I personally do not like blaming the last person who touched
   the file, but that is probably just me so it is fine.

 - "Commit" column does not seem to convey much useful
   information; I would suggest perhaps making Date and/or
   Author clickable to take the browser to the commit, but I do
   not understand what the strike-through is about...

 - Since the rightmost links have quite a lot of information
   these days, it _might_ be reasonable to make the main part
   2 lines, like so:

	date    author   mode    path
        short-commit-log-message

	date    author   mode    path
        short-commit-log-message

...

 - I wonder how expensive it is to generate this.