git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] svnimport add support for parsing From lines for author

From
Junio C Hamano <junkio@cox.net>
Date
Sep 27, 2006, 05:34 UTC
Message-ID
<7vfyedj2j2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<4518DC11.5050806@shadowen.org>
Andy Whitcroft <apw@shadowen.org> writes:
Show 14 quoted lines
>>> Now that we have support for parsing Signed-off-by: for author
>>> information it makes sense to handle From: as well.
>> 
>> I take that you are referring to Sasha's change in ae35b304; I
>> asked for actual svn users for ACK/NACK but I did not hear any.
>> Can I understand that you use svnimport for real projects and
>> are happy with Sasha's change? --- that would be an ack that
>> would help me sleep better ;-).
>
> Heh.  Yeah I am tracking a small SVN repository which is using the
> kernel DCO.  we have From:/S-o-b: much as akpm uses in -mm.  This was
> the result of seeing that change and wanting to see if it would pick up
> our sign-offs.  It only seemed deficient in From: handling :).  It seems
> to work well in practice for me.
Thanks.
Show 14 quoted lines
>> I also wonder instead of piling up custom flags if it is better
>> to let match-and-extract pattern be specified from the command
>> line.
>
> I did look at reusing the -S flag, such that -S would be S-o-b: handling
> and -SS would be S-o-b: and From:, but this script is currently using
> the old getopt implementation which doesn't record repeats.
>
> So you're proposing something more like:
>
>     git svn-import -S "Signed-off-by:" -S "From:" ...
>
> Again, we'll have to update the options handling to get that kind of
> behaviour.  How would you feel about -SS in this context.

It was more of an idle speculation than a serious proposal. I do not think there are too many different ways to record the authorship information, so having just two hardwired patterns -F and -S would be sufficient. If there were, then string of -S options that specify the header-looking strings or match patterns would have made more sense.

Previous: Andy WhitcroftNext: Andy Whitcroft
Message 4 of 6 in “svnimport add support for parsing From lines for author”
  1. svnimport add support for parsing From lines for authorAndy Whitcroft, Sep 25, 2006
  2. Junio C HamanoSep 26, 2006
  3. Andy WhitcroftSep 26, 2006
  4. Junio C HamanoSep 27, 2006
  5. Andy WhitcroftSep 28, 2006
  6. Junio C HamanoSep 28, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.