git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] gitweb: New improved formatting of chunk header in diff

From
Junio C Hamano <junkio@cox.net>
Date
Nov 8, 2006, 20:41 UTC
Message-ID
<7vfyctsmbm.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<200611081800.16001.jnareb@gmail.com>

This regresses on hunks of form "@@ -n +m,l @@" and friends, so I dropped it for now.

I've applied other three patches but with manual tweaks while I demangled the linewrap, so please sanity check the result after it mirrors out. I also noticed that we unconditionally give blame link in "diff-tree --name-status" part of commitdiff, so I've fixed it up as well.

I think you still leak control characters in commit messages and htmlized blob text view; and perhaps others like blame. I have made quot_cec into a separate sub that is callable from outside esc_path, so these places should be able to reuse it to make control characters "visible and safe" and keep the presentation consistent. The non-path callers would not feed tabs into the function (I haven't looked at the code but I suspect you would replace them into runs of spaces to the next tab stop by hand), but other controls need to be quoted.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 11 of 16 in “Better unquoting of git quoted filenames; esc_path to escape pathnames for display”
  1. 0/2 Better unquoting of git quoted filenames; esc_path to escape pathnames for displayJakub Narebski, Nov 8, 2006
  2. 1/2 gitweb: Better git-unquoting and gitweb-quoting of pathnamesJakub Narebski, Nov 8, 2006
  3. 2/2 gitweb: Use character or octal escape codes (and add span.cntrl) in esc_pathJakub Narebski, Nov 8, 2006
  4. 0/2 gitweb: New improved patchset viewJakub Narebski, Nov 8, 2006
  5. 1/2 gitweb: New improved patchset viewJakub Narebski, Nov 8, 2006
  6. Junio C HamanoNov 8, 2006
  7. Junio C HamanoNov 8, 2006
  8. Jakub NarebskiNov 8, 2006
  9. 1/2 gitweb: New improved patchset viewJakub Narebski, Nov 8, 2006
  10. 2/2 gitweb: New improved formatting of chunk header in diffJakub Narebski, Nov 8, 2006
  11. Junio C HamanoNov 8, 2006
  12. Jakub NarebskiNov 8, 2006
  13. Junio C HamanoNov 8, 2006
  14. Jakub NarebskiNov 8, 2006
  15. Junio C HamanoNov 8, 2006
  16. Jakub NarebskiNov 8, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.