git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFT] Work around http-fetch built with cURL 7.16.0

From
Junio C Hamano <junkio@cox.net>
Date
Dec 29, 2006, 00:40 UTC
Message-ID
<7vfyazttzm.fsf_-_@assigned-by-dhcp.cox.net>
In-Reply-To
<7v8xgt57wu.fsf@assigned-by-dhcp.cox.net>

It appears that curl_easy_duphandle() from libcurl 7.16.0 returns a curl session handle which fails GOOD_MULTI_HANDLE() check in curl_multi_add_handle(). This causes fetch_ref() to fail because start_active_slot() cannot start the request.

For now, check for 7.16.0 to work this issue around.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 * I think people who were having trouble with cURL 7.16.0 want
   to have the issue resolved before v1.5.0-rc1.  Please test
   and report, or else ;-).
 http.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/http.h b/http.h
index 6e12e41..324fcf4 100644
--- a/http.h
+++ b/http.h
@@ -18,7 +18,7 @@
 #define curl_global_init(a) do { /* nothing */ } while(0)
 #endif
 
-#if LIBCURL_VERSION_NUM < 0x070c04
+#if (LIBCURL_VERSION_NUM < 0x070c04) || (LIBCURL_VERSION_NUM == 0x071000)
 #define NO_CURL_EASY_DUPHANDLE
 #endif
 
-- 
1.5.0.rc0.gf5c587
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “Re: http git and curl 7.16.0”
  1. Horst H. von BrandDec 27, 2006
  2. Junio C HamanoDec 27, 2006
  3. Junio C HamanoDec 27, 2006
  4. Work around http-fetch built with cURL 7.16.0Junio C Hamano, Dec 29, 2006
  5. Junio C HamanoJan 1, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.