Re: [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to

From: Junio C Hamano <junkio@cox.net>
Date: Jan 7, 2007, 21:10 UTC
Message-ID: <7vfyam1r18.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4c8ef70701070456k2f0585f4ga6c35bd77c939c59@mail.gmail.com>

"Fredrik Kuivinen" <frekui@gmail.com> writes:

Show 13 quoted lines

>> >     I think we need to delimit the name better, probabally we need to quote
>> >     it.  Perhaps something like:
>> >
>> >     HEAD is now at ac9c110: "git-fetch: remove .keep file at the end".
>> ...
> I don't think the second point is much of an issue. Is it really that
> irritating to
> read a word-wrapped line of text? I agree with the first point though, in most
> cases it will not be a problem in other projects.
>
> I still think it is worth doing it, but it certainly isn't super
> important. Feel free
> to drop the patch if you want to.

I do not care much either way, but the third point is that the quoted output would look "interesting" if the original title text has double-quoted words. I.e.

    HEAD is now at 9945d98: "Add "--cacheinfo" option to update-cache."

Notice also your hand-wrapped example has the final full-stop outside the quote, which your patch would not produce ;-).