Re: [PU PATCH] Fix git fetch for very large ref counts
- From
Junio C Hamano <junkio@cox.net>
- Date
- Feb 13, 2007, 17:58 UTC
- Message-ID
- <7vfy9ax7l6.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0702131031180.6435@reaper.quantumfyre.co.uk>
Julian Phillips <julian@quantumfyre.co.uk> writes:
> And there I was thinking 0.5m was fast ... given how long I've been > reading this list I really should have know better. ;)
Well, the only thing we need to do in fetching between two repositories that are already identical should be to compare ls-remote output from both ends and immediately declare victory, and it is unacceptable for such an obvious no-op to take 30 seconds. At this point it really is the shell loop that is killing us.
> I only really made the changes so I could try your improvements to > fetch out - if they aren't necessary because you're making it even > faster then I really don't have much cause to complain.
I've applied your fixes to jc/fetch topic and merged it back to 'pu'. Thanks.