Re: [PATCH] Add a compat/strtoumax.c for Solaris 8.

From: Junio C Hamano <junkio@cox.net>
Date: Feb 20, 2007, 02:20 UTC
Message-ID: <7vfy9136zu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070220003533.GB28314@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 14 quoted lines

> Jason Riedy <ejr@EECS.Berkeley.EDU> wrote:
>> Solaris 8 was pre-c99, and they weren't willing to commit to
>> the strtoumax definition according to /usr/include/inttypes.h.
>> 
>> This adds NO_STRTOUMAX and NO_STRTOULL for ancient systems.
>> If NO_STRTOUMAX is defined, the routine in compat/strtoumax.c
>> will be used instead.  That routine passes its arguments to
>> strtoull unless NO_STRTOULL is defined.  If NO_STRTOULL, then
>> the routine uses strtoul (unsigned long).
>
> Ack'd (this and the fast-import patch that follows).
>
> This is a better version than the patch I sent out last night,
> so Junio please drop my patch in favor of Jason's.

Yours talk about Sol 9 and Jason talks about Sol 8. Should I take your ack to mean you want this patch on top of Jason's?

diff --git a/Makefile b/Makefile
index 821996f..f85fb7c 100644
--- a/Makefile
+++ b/Makefile
@@ -358,16 +358,17 @@ ifeq ($(uname_S),SunOS)
 		NO_SETENV = YesPlease
 		NO_C99_FORMAT = YesPlease
 		NO_STRTOUMAX = YesPlease
 	endif
 	ifeq ($(uname_R),5.9)
 		NO_UNSETENV = YesPlease
 		NO_SETENV = YesPlease
 		NO_C99_FORMAT = YesPlease
+		NO_STRTOUMAX = YesPlease
 	endif
 	INSTALL = ginstall
 	TAR = gtar
 	BASIC_CFLAGS += -D__EXTENSIONS__
 endif
 ifeq ($(uname_O),Cygwin)
 	NO_D_TYPE_IN_DIRENT = YesPlease
 	NO_D_INO_IN_DIRENT = YesPlease