Re: [PATCH/RFC] git-cvsserver: Add a basic test file for cvsserver

From: Junio C Hamano <junkio@cox.net>
Date: May 1, 2007, 08:50 UTC
Message-ID: <7vfy6h7wsb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11778774271937-git-send-email-frank@lichtenheld.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

Show 16 quoted lines

> Contains only one test (checkout) at this point and is
> mostly indented to be used as a RFC to discuss
> how to properly implement tests for git-cvsserver.
>
> Currently the test uses netcat to run git-cvsserver
> pserver on a unprivilegded port.
>
> Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> ---
>  t/t9400-git-cvsserver-read.sh |   56 +++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 56 insertions(+), 0 deletions(-)
>  create mode 100644 t/t9400-git-cvsserver-read.sh
>
>  Since this is my first test script for git I would welcome comments
>  and suggestions. Especially if someone has a simpler method of
>  testing it than the somewhat fragile netcat hack I used.

Yes, before reading this three-line paragraph, use of netcat and hardcoded port number made my eyebrows raise.

But a git-cvsserver test suite that can be run from "make test" is a really good thing to have for us.

I haven't pursued this but have you considered :fork: connect method instead of :ext:, so that you do not have to use pserver nor ssh connection?