git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: favor ~/.subversion/ ssl client cert settings

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2007, 00:25 UTC
Message-ID
<7vfy4kbztn.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To
<11824677432401-git-send-email-hacker@klever.net>
Sorry, but I am not familiar with SVN API.

In plain English, what does this change mean and what does it buy us? An expected answer is something like:

	Without this change, there is no way to authenticate
        with client SSL certificates, as certificates registered
        in ~/.subvsersion are ignored.

BTW, if that is what you meant, it contradicts the word "favor" in the proposed commit title. "Favor" would mean "We do support it already but in lower precedence than something else, which is inconvenient, so let's move it up so that it is used if found without bothering other possibilities".

If that is what you really meant, then the answer would be in the form of:

	Curently, even when the client wants to use SSL
        certificate to authenticate with the server, X
        authenticator is tried first which causes Y that is
        irritating.  This patch makes the client certificate
        authenticator be tried first.

But if that is what is going on, we need to judge if the "irritation" factor is universally true, or just affects people who want to use client SSL cert; if the change makes it more convenient for client cert people by making it less convenient for others, the relative merit needs to be debated to justify the change.

I am guessing that you meant the former (we currently totally ignore it, and the patch adds the missing support), but what would I know...

And if that is the case, then I think the word you wanted to use is not "favor" but "honor".

In any case, the patch needs a handful lines of proposed commit log message to explain and justify the change, like the above two examples I showed here.

Previous: Michael Krelin
Message 2 of 2 in “git-svn: favor ~/.subversion/ ssl client cert settings”
  1. git-svn: favor ~/.subversion/ ssl client cert settingsMichael Krelin, Jun 21, 2007
  2. Junio C HamanoJun 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.