Re: [PATCH] git-svn: cache max revision in rev_db databases
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 1, 2007, 03:50 UTC
- Message-ID
- <7vfy48940k.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <11831937823184-git-send-email-sam.vilain@catalyst.net.nz>
Sam Vilain <sam.vilain@catalyst.net.nz> writes:
Show 5 quoted lines
> Cache the maximum revision for each rev_db URL rather than looking it > up each time. This saves a lot of time when rebuilding indexes on a > freshly cloned repository. > > Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>
I think both the previous one from Sam that makes it use git-log instead of git-rev-list and this one looks sane. Ack/Nack is appreciated.
Show 33 quoted lines
> ---
> git-svn.perl | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 556cd7d..a8b6669 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -801,6 +801,7 @@ sub working_head_info {
> my ($head, $refs) = @_;
> my ($fh, $ctx) = command_output_pipe('log', $head);
> my $hash;
> + my %max;
> while (<$fh>) {
> if ( m{^commit ($::sha1)$} ) {
> unshift @$refs, $hash if $hash and $refs;
> @@ -810,11 +811,14 @@ sub working_head_info {
> next unless s{^\s*(git-svn-id:)}{$1};
> my ($url, $rev, $uuid) = extract_metadata($_);
> if (defined $url && defined $rev) {
> + next if $max{$url} and $max{$url} < $rev;
> if (my $gs = Git::SVN->find_by_url($url)) {
> my $c = $gs->rev_db_get($rev);
> if ($c && $c eq $hash) {
> close $fh; # break the pipe
> return ($url, $rev, $uuid, $gs);
> + } else {
> + $max{$url} ||= $gs->rev_db_max;
> }
> }
> }
> --
> 1.5.2.1.1131.g3b90