Re: [PATCH] gitweb: make search form generate pathinfo-style URLs

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 2, 2007, 23:11 UTC
Message-ID: <7vfy46wgdg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1183402981.2664.10.camel@mattlaptop2>

Matt McCutchen <hashproduct@gmail.com> writes:

> I sent this patch four days ago but no one has commented or done
> anything about it.  Please clue me in: is this typical, or did I do
> something wrong or do I need to do something else?

Yes, it sometimes happens to patches to some areas. No, you did not do anything wrong as far as I can see. Yes, sending this kind of reminder out is exactly what is needed.

I have three recent patches from you on gitweb in my patch queue.

  Subject: [PATCH] gitweb: snapshot cleanups & support for offering multiple
          formats
  Date: Thu, 28 Jun 2007 14:02:13 -0400
  Message-ID: <1183053733.6108.0.camel@mattlaptop2>

  Subject: [PATCH] gitweb: make search form generate pathinfo-style URLs
  Date: Thu, 28 Jun 2007 14:57:07 -0400
  Message-ID: <1183057027.6108.4.camel@mattlaptop2>

  Subject: [PATCH] gitweb: make "No commits" in project list gray, not bold
          green
  Date: Thu, 28 Jun 2007 18:15:22 -0400
  Message-ID: <1183068922.6108.8.camel@mattlaptop2>

There are people whom I consider "gitweb folks", who are more familiar with, and more importantly who are more interested in, gitweb than I am. Having good "subsystem people" makes gitweb a lower-priority area to myself, and for these patches it made even so that nobody commented on them.

I should have asked Ack/Nack/Comments from gitweb folks much earlier, but was a bit too loaded with the day job. Sorry about that.

So, gitweb folks, what do you think about these patches?