Re: [PATCH 3/5] Clean up work-tree handling

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 26, 2007, 22:31 UTC
Message-ID: <7vfy3a7q5p.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070726220949.GA4420@moooo.ath.cx>

Matthias Lederhofer <matled@gmx.net> writes:

Show 16 quoted lines

> I try to take a closer look at your changes tomorrow evening.  Here
> are just two short things I saw while taking a short look at the
> patch.
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> +const char *get_git_work_tree(void)
>> +{
>> +	static int initialized = 0;
>> +	if (!initialized) {
>> +		work_tree = getenv(GIT_WORK_TREE_ENVIRONMENT);
>> +		if (!work_tree) {
>> +			work_tree = git_work_tree_cfg;
>> +			if (work_tree && !is_absolute_path(work_tree))
>> +			work_tree = git_path(work_tree);
>
> A tab is missing here.

I think xstrdup() is missing here, too.