Re: [PATCH 2/3] git-help: add -w|--web option to display html man page in a browser.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2007, 07:05 UTC
Message-ID: <7vfxyf7zoi.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v1w9z9h2k.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Christian Couder <chriscool@tuxfamily.org> writes:
> ...
>>> > +init_browser_path() {
>>> > +	browser_path=`git config browser.$1.path`
>>> > +	test -z "$browser_path" && browser_path=$1
>>> > +}
>>>
>>> Please do not contaminate the config file with something the user can
>>> easily use a lot more standardized way (iow $PATH) to configure to his
>>> taste.
>>>
>>> I'd suggest dropping this bit.

Well, I changed my mind. It is a bit funny to have both firefox and iceweasel as "valid-tool", but if we consider $browser to define the external interface and $browser_path to define the implementation, it sort of makes sense to have that configuration. browser_path could be iceweasel for browser firefox.

I'll squash the patch to update the one from the last round (as the last two patches are not yet accepted in 'next' yet), remove the html documentation path fallback, but will leave this part in.

browser.*.path and web.browser configuration need to be documented, if not already, though.