Re: [BUGS] test failure in t4014-format-patch.sh with master

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2008, 06:51 UTC
Message-ID: <7vfxtiibhf.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <6b8a91420804181513m139baf06x41d8efeb7acd49a3@mail.gmail.com>

"Rémi Vanicat" <vanicat@debian.org> writes:

Show 17 quoted lines

> 2008/4/18, Linus Torvalds <torvalds@linux-foundation.org>:
>>
>>
>>  On Fri, 18 Apr 2008, Junio C Hamano wrote:
>>  >
>>  > -             (echo "$SUBJECT" ; echo ; cat "$dotest/msg") |
>>  > +             (printf '%s\n' "$SUBJECT" ; echo ; cat "$dotest/msg") |
>>
>>
>> Well, get rid of the superfluous second 'echo' then too, replacing it
>>  with another '\n'. IOW:
>>
>>         ( printf '%s\n\n' "$SUBJECT" ; cat "$dotest/msg" ) |
>>
>>  instead.
>
> This work for me: no more test failure on my computer

Thanks for confirmation. I reproduced the breakage and the fix myself with "make SHELL_PATH=/bin/dash" myself, too.