Re: [PATCH] revisions: refactor handle_revision_opt into parse_revision_opt.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2008, 07:36 UTC
- Message-ID
- <7vfxqiqjgd.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080710071418.GD3195@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> but it also seems like the top bit of that for loop is boilerplate, too:
>
>> for (;;) {
>> switch (parse_options_step(&ctx, options, shortlog_usage)) {
>> case PARSE_OPT_HELP:
>> exit(129);
>> case PARSE_OPT_DONE:
>> goto parse_done;
>> }Another thing we should be able to refactor is the option help formatter. Cf. 071438a (Teach git-merge -X<option> again., 2008-07-09)