Re: [PATCH] Adjust for the new way of enabling the default post-update hook

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 11, 2008, 22:57 UTC
Message-ID: <7vfxpbuplr.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080811223446.8342.37008.stgit@localhost>

Petr Baudis <pasky@suse.cz> writes:

> The post-update hook, which is required to be enabled in order for
> the repository to be accessible over HTTP, is not enabled by
> chmod a+x anymore, but instead by dropping the .sample suffix.

Thanks for attention to the details.

> This patch emphasizes this change in the release notes (since
> I believe this is rather noticeable backwards-incompatible change).

Anybody who tries to chmod an nonexisting file would notice, so I personally think you are making a mountain out of a molehill.

Nevertheless, mentioning it in the release notes would be a good finishing touch.

> +The standard way of making repositories friendly to dumb protocols
> +(i.e. HTTP) changed: instead of making hooks/post-update executable,
> +hooks/post-update.sample is to be moved to hooks/post-update.

I'm actually not very happy with the above wording that makes it sound as if any of the samples are part of any "standard way".

The only standard thing is to make sure update-server-info runs. You do not have to start from the sample hook to do so, even though it may be one of the easiest ways.

The rest of the patches look good, but have you actually made sure AsciiDoc markups are correct (I am not complaining, just asking, as I haven't)?