git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t91XX-svn: start removing use of "git-" from these tests

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 9, 2008, 08:40 UTC
Message-ID
<7vfxo9af0o.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080909022343.GB19190@toroid.org>
Abhijit Menon-Sen <ams@toroid.org> writes:
Show 8 quoted lines
> At 2008-09-08 03:27:59 -0700, normalperson@yhbt.net wrote:
>>
>> They'll show up as false positives when grepping for "git-"
>
> Fine, you're the maintainer, but for the record, I think this change is
> dreadful. Changing all "git-svn blah" commands to "git svn blah" is one
> thing, but obfuscating tests on the off-chance that someone might grep
> for "git-" seems entirely wrong.

I think the value of this first one is not "on the off-chance" thing, but the presense of this change makes it far easier to eyeball the result of applying the second, large-ish patch.

If I were doing this as a series, I would probably have followed them up with a patch that reverts the token replacement this first one does as the final patch in the series, but I also think leaving this first patch as-is is fine.

Previous: Abhijit Menon-Sen
Message 5 of 5 in “t/t91XX-svn: start removing use of "git-" from these tests”
  1. t/t91XX-svn: start removing use of "git-" from these testsNanako Shiraishi, Sep 8, 2008
  2. Abhijit Menon-SenSep 8, 2008
  3. Eric WongSep 8, 2008
  4. Abhijit Menon-SenSep 9, 2008
  5. Junio C HamanoSep 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.