Re: [RFC PATCH] diff --no-index: test for pager after option parsing
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 7, 2009, 00:09 UTC
- Message-ID
- <7vfxjwf041.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1231286163-9422-1-git-send-email-trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
> I noticed this while working on the earlier patch for diff --no-index. > It seems like the right thing to do (and passes tests), but I don't > have a clue about git's normal setup sequences, so I'm flagging it > RFC.
I think the patch itself makes sense from the logic flow point of view.
But I wonder if it still makes a difference in real life.idn't we stop reporting the exit status from the pager some time ago?