Re: [PATCH] Makefile: Use libc strlcpy on OSX

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2009, 18:39 UTC
Message-ID: <7vfxj8o8fq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7f978c810901240741k201f954dx1c0470186094ae24@mail.gmail.com>

Benjamin Kramer <benny.kra@googlemail.com> writes:

> OSX supports strlcpy(3) since 10.2 so we don't need
> to use our own.

How does your patch to Makefile refrain from kicking in for people with OSX older than 10.2, so that their builds are not broken?

Show 18 quoted lines

>
> Signed-off-by: Benjamin Kramer <benny.kra@gmail.com>
> ---
>  Makefile |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b4d9cb4..4c9aab5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -643,7 +643,6 @@ ifeq ($(uname_S),Darwin)
>  	ifneq ($(shell expr "$(uname_R)" : '9\.'),2)
>  		OLD_ICONV = UnfortunatelyYes
>  	endif
> -	NO_STRLCPY = YesPlease
>  	NO_MEMMEM = YesPlease
>  	THREADED_DELTA_SEARCH = YesPlease
>  endif