Re: "malloc failed"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2009, 07:53 UTC
Message-ID: <7vfxj2h7ka.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090129055633.GA32609@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> Subject: [PATCH] avoid 31-bit truncation in write_loose_object
>
> The size of the content we are adding may be larger than
> 2.1G (i.e., "git add gigantic-file"). Most of the code-path
> to do so uses size_t or unsigned long to record the size,
> but write_loose_object uses a signed int.

Thanks.

I wonder if some analysis tool like sparse can help us spot these...