Re: [PATCH RFC3 05/13] send-email: Cleanup the usage text and docs a bit
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 14, 2009, 06:46 UTC
- Message-ID
- <7vfxgb91hc.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <b4087cc50904132300m391ac4ffn6a41ecc5cdcb6ed8@mail.gmail.com>
Michael Witten <mfwitten@gmail.com> writes:
> The usage text for --smtp-server currently has <host:port>, which > doesn't work when 'ssl' is used for the connection to the server.
Ah, I see. But it does work when ssl is not used, right? A possible solution would be one of:
- support host:port in SSL codepath (shouldn't it be trivial?);
- split the description in the documentation to clarify it does not work for SSL; or
- remove host:port support to make both consistent.
To me, the last one makes the least sense. Is that the approach you are taking?