Re: [PATCH] Fix compiler warning by properly initialize failed_errno

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 4, 2009, 22:22 UTC
Message-ID: <7vfxc7dxsf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090804092759.24120@gmx.net>

"sn_" <sn_@gmx.net> writes:

Show 15 quoted lines

>> The potentially uninitialized use your compiler is worried about is inside
>> if (cmd->pid < 0) after #ifdef/#else/#endif.
>> 
>>  (1) if not on MINGW32, we would have already assigned to failed_errno
>>      after fork() returns negative value to cmd->pid;
>> 
>>  (2) if on MINGW32, we would have assigned to failed_errno unconditionally
>>      after calling mingw_spawnvpe().
>> 
>> so its worry is unfounded.
>
> The worry is definatly unfounded, but I think it's still worth to apply
> the attached patch to get rid of the warning using the
> i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490)
> compiler. I sended a corrected version of the patch to the ml.

Oh, there was no need for you to say "but..." and everything that followed. I said "we should say ... instead" in my review comments, didn't I?

We are obviously in agreement ;-)