Re: [PATCH] git-push: Accept -n as a synonym for --dry-run.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 13, 2009, 02:44 UTC
- Message-ID
- <7vfxar5zsi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1252800302-26560-1-git-send-email-nelhage@mit.edu>
Nelson Elhage <nelhage@MIT.EDU> writes:
> '-n' is the standard way to specify a dry run for other git commands, > so make 'git-push' accept it as well. > ---
Sign-off?
Indeed -n is used in many places for --dry-run, but it is not _the_ standard way.
commit, push (as you identified), reflog, and send-email have --dry-run but -n is not a synonym for it. Some of them even use -n as a shorthand for a more often used option than --dry-run.
So the justification should be more like "push does not any other option that deserves a short-and-sweet -n better, it will not have any such option in the future, and --dry-run is very often used that it deserves to use -n as its short-hand."
I tend to agree with the first two points, but I am not sure about the third point. Do people dry-push that often?