Re: [PATCH] add new options to git format-patch: --cover-subject and --cover-blurb

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 5, 2010, 22:33 UTC
Message-ID: <7vfx5fwbws.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201002051526.18205.wjl@icecavern.net>

"Wesley J. Landaker" <wjl@icecavern.net> writes:

Show 15 quoted lines

> On Friday 05 February 2010 14:39:33 Larry D'Anna wrote:
>> This is useful because if you're preparing a patch series with a cover
>>  letter you can easily put together one line to format and email the
>>  whole thing to yourself.  You check to make sure everything is right,
>>  and then just change the recipient address and run it again.
>> 
>> git send-email --to my@mydomain.org  master..HEAD --cover-letter \
>>     --cover-subject "this is my patch series" --cover-blurb "$(cat
>>  blurb.txt)"
>
> One (minor?) issue is that the cover blub would be limited to the maximum 
> allowed length of the command-line arguments set by the shell or OS. Since 
> you are just catting a file, maybe "--cover-blub-file" would be better?
>
> Just a thought.

The placeholder in particular and the cover letter itself in general are meant to be edited. I do not see much point in forcing people to edit yet another file and have them specify with an cover-blurb option.

Not very interested.