git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-cvsimport: strip question-mark characters in tags

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 14, 2010, 14:29 UTC
Message-ID
<7vfx2yqf9s.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100414133831.GA12135@f.santiago.vpn.redhat.com>
Ed Santiago <santiago@redhat.com> writes:
> Question mark character appears to be valid in a CVS tag,
> but not a git one.  Remove it.  Leave open the possibility that there may
> be more such characters; and comment (FIXME) that we may want to replace
> those instead of removing them.

I agree that people may want to optionally replace them to avoid mapping two originally different tags into the same one.

Does your regexp chain check other invalid refname sequences, such as ".name", "na..me", etc.?

> Also: if git tag command fails, do not include $! in our
> error message: it is not useful after system(), and will
> only serve as a red herring.
> ---
Sign-off?
Previous: Ed SantiagoNext: Ed Santiago
Message 2 of 7 in “git-cvsimport: strip question-mark characters in tags”
  1. git-cvsimport: strip question-mark characters in tagsEd Santiago, Apr 14, 2010
  2. Junio C HamanoApr 14, 2010
  3. Ed SantiagoApr 14, 2010
  4. Junio C HamanoApr 14, 2010
  5. Andreas SchwabApr 14, 2010
  6. Ed SantiagoApr 14, 2010
  7. Johan HerlandApr 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.