Re: [PATCHv2 GSOC 01/11] gitweb: fix esc_url

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 15, 2010, 18:57 UTC
Message-ID: <7vfwzkvahf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201007151552.23324.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 24 quoted lines

> On Thu, 15 Jul 2010, Pavan Kumar Sunkara wrote:
>> The custom CGI escaping done in esc_url failed to escape UTF-8
>> properly. Fix by using CGI::escape on each sequence of matched
>> characters instead of sprintf()ing a custom escaping for each byte.
>> 
>> Additionally, the space -> + escape was being escaped due to greedy
>> matching on the first substitution. Fix by adding space to the
>> list of characters not handled on the first substitution.
>> 
>> Finally, remove an unnecessary escaping of the + sign.
>> 
>> commit 452e225 has missed fixing esc_url.
>> 
>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
>
> First, as this patch is independent and unrelated to either splitting
> gitweb, or write support, it would be better if this patch was sent
> individually to git mailing list, and not only as a part of a large
> patch series.  It would likely to be applied, as it is pure bugfix.
>
> Second, I would probably write commit message differently, to emphasize
> that it is just finishing work of commit 452e225 (gitweb: fix esc_param,
> 2009-10-13) by fixing esc_url like it fixed esc_params.  But it is not
> something very important.

I tentatively rewrote the message like so:

    Earlier, 452e225 (gitweb: fix esc_param, 2009-10-13) fixed CGI
    escaping rules used in esc_url.  A very similar logic exists in
    esc_param and needs to be fixed the same way.

It makes one wonder why they have to be separate functions, doesn't it, though?

> For what it is worth, ACK from me for this patch.

Thanks