Re: [PATCH v6.1 4/8] Implement line-history search (git log -L)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2010, 00:20 UTC
- Message-ID
- <7vfwtzrin3.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <426fca7313fc9466efa036b7b86947f23548fc26.1292366984.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 15 quoted lines
> +void line_log_init(struct rev_info *rev, struct diff_line_range *r)
> +{
> + struct commit *commit = NULL;
> + struct diff_options *opt = &rev->diffopt;
> +
> + commit = (struct commit *)verify_commit(rev);
> + parse_lines(commit, r);
> +
> + add_line_range(rev, commit, r);
> + /*
> + * Note we support -M/-C to detect file rename
> + */
> + opt->nr_paths = 0;
> + diff_tree_release_paths(opt);
> +}Note that opt->nr_paths may be going away soon (cf. nd/struct-pathspec topic). Do you need this assignment here?