Re: [PATCH] completion: simplify __git_complete_revlist_file

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2012, 23:39 UTC
Message-ID: <7vfwbj79od.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1335897776-3726-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 10 quoted lines

> Use new __gitcomp_nl; this is the last place that uses COMPREPLY and
> compgen directly.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 31f714d..d877a23 100755

This seems to be based on 'maint', which has 31f714d, but I see two hits with "git grep 'COMPREPLY.*compgen' contrib/completion" there, so I am not sure if that is where you wanted it to apply.

I see this was not addressed to me (neither was the other zsh one), so I take it that the patch is still for discussion, at least for the purpose of today's integration round. Ping me when it is ready for either 'pu' or 'next'.

Thanks.