git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add userdiff patterns for Ada

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 17, 2012, 04:59 UTC
Message-ID
<7vfw6hxn12.fsf@alter.siamese.dyndns.org>
In-Reply-To
<50557D72.60205@redneon.com>
Adrian Johnson <ajohnson@redneon.com> writes:
Show 8 quoted lines
>> I do not seem to find anything interesting after @@, which means
>> that xfuncname is not tested at all even though the log message
>> claims the patch adds some.
>
> I probably misunderstood how the tests work. I thought t4034 tested
> wordRegex while t4018 is for xfuncname. I based the Ada tests on the
> Pascal tests but changed the operators to Ada operators. I'm not really
> sure what else the test needs.

The per-language for-loop you added ada to in t4018 is only to make sure there is no regexp syntax error in the built-in xfuncname, and does not check if the patterns make sense for the language at all.

You could add test vectors to check if the built-in xfuncname catches beginning of functions in Ada correctly if you wanted to, but I think observing what appears on @@ lines in t4034 test vector would be a sufficient test.

Previous: Adrian Johnson
Message 4 of 4 in “Add userdiff patterns for Ada”
  1. Add userdiff patterns for AdaAdrian Johnson, Sep 16, 2012
  2. Junio C HamanoSep 16, 2012
  3. Adrian JohnsonSep 16, 2012
  4. Junio C HamanoSep 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.