git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git svn: consistent spacing after "W:" in warnings

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 8, 2013, 16:06 UTC
Message-ID
<7vfw05ho4r.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130308100152.GA32643@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 6 quoted lines
> Eric Wong <normalperson@yhbt.net> wrote:
>> will push another change for formatting existing warnings more
>> consistently.
>
>   Just pushed.  My master is sitting at git://git.bogomips.org/git-svn.git
>   commit eae6cf5aa8ae2d8a90a99bbe4aeb01c29e01fd02
Thanks.
Show 35 quoted lines
>
>   Eric Wong (1):
>         git svn: consistent spacing after "W:" in warnings
>
>   Jan Pešta (1):
>         git svn: ignore partial svn:mergeinfo
>
>   I don't have further updates planned, maybe others do.
> ----------------------------8<------------------------------
> From eae6cf5aa8ae2d8a90a99bbe4aeb01c29e01fd02 Mon Sep 17 00:00:00 2001
> From: Eric Wong <normalperson@yhbt.net>
> Date: Fri, 8 Mar 2013 09:46:41 +0000
> Subject: [PATCH] git svn: consistent spacing after "W:" in warnings
>
> All other instances of "W:"-prefixed warning messages have a space after
> the "W:" to help with readability.
>
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>  perl/Git/SVN.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
> index 46aeb85..5273ee8 100644
> --- a/perl/Git/SVN.pm
> +++ b/perl/Git/SVN.pm
> @@ -1504,7 +1504,7 @@ sub lookup_svn_merge {
>  		my $top_commit = $gs->find_rev_before( $top, 1, $bottom );
>  
>  		unless ($top_commit and $bottom_commit) {
> -			warn "W:unknown path/rev in svn:mergeinfo "
> +			warn "W: unknown path/rev in svn:mergeinfo "
>  				."dirprop: $source:$range\n";
>  			next;
>  		}
Previous: Eric Wong
Message 4 of 4 in “git svn: ignore partial svn:mergeinfo”
  1. git svn: ignore partial svn:mergeinfoJan Pešta, Mar 7, 2013
  2. Eric WongMar 8, 2013
  3. git svn: consistent spacing after "W:" in warningsEric Wong, Mar 8, 2013
  4. Junio C HamanoMar 8, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.