git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] diff-cache.c compilation warning fix.

From
Junio C Hamano <junkio@cox.net>
Date
Apr 28, 2005, 04:15 UTC
Message-ID
<7vekcvbkq8.fsf@assigned-by-dhcp.cox.net>

Nobody uses return value from show_new_file() function but it is defined as returning int and falls off at the end without returning. Make it void.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff-cache.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)

# - [PATCH] diff-tree -p implies diff-tree -p -r # + working tree --- k/diff-cache.c +++ l/diff-cache.c

@@ -38,7 +38,7 @@ static int get_stat_data(struct cache_en
 	return 0;
 }
 
-static int show_new_file(struct cache_entry *new)
+static void show_new_file(struct cache_entry *new)
 {
 	unsigned char *sha1;
 	unsigned int mode;
Next: Junio C Hamano
Message 1 of 2 in “diff-cache.c compilation warning fix.”
  1. diff-cache.c compilation warning fix.Junio C Hamano, Apr 28, 2005
  2. diff-cache.c compilation warning fix.Junio C Hamano, Apr 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.