Re: git-diff-tree rename detection bug

From: Junio C Hamano <junkio@cox.net>
Date: Sep 15, 2005, 07:41 UTC
Message-ID: <7vek7qbwws.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <43290DA0.3030402@zytor.com>

"H. Peter Anvin" <hpa@zytor.com> writes:

Show 9 quoted lines

> Paul Mackerras wrote:
>> I assume you're compiling git as 32-bit executables on your G5.  I
>> don't see any reason why the git binaries would need to be 64-bit.
>>
>
> Well, git seems to assume it can mmap() the entirety of any file under 
> its control, so a 64-bit git could handle larger files.
>
> Still, I'm using 32-bit git on ppc64.

Which is a valid thing to do because git also assumes that a file offset fits within 32-bit as far as I know. Each object in a packfile should also fit in 32-bit offset and the size of one packfile also needs to be within 32-bit offset. I was unsure if the last limitation would cause problems in the real life but we will see in a couple of years ;-).