Re: [RFC] Cleaning up die() error messages

From: Junio C Hamano <junkio@cox.net>
Date: Oct 12, 2005, 05:02 UTC
Message-ID: <7vek6rnx8z.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <434C93C5.9040505@zytor.com>

"H. Peter Anvin" <hpa@zytor.com> writes:

> Not unless any of those linked structures can be reached from outside 
> the git library.

OK. How about things like open file descriptors and mmap'ed regions then? That is:

    fd = open();
    xmalloc(); /* may die now */
    close(fd);

I think in the long run we would be better off if we properly dealt with the case where (x)malloc returns NULL. Of course, that would make libification a bigger task, so we do not have to do it from day one.