Re: [PATCH 3/4] Server-side support for user-relative paths.

From: Junio C Hamano <junkio@cox.net>
Date: Nov 2, 2005, 00:14 UTC
Message-ID: <7vek5z6h3f.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051101225921.3835C5BF73@nox.op5.se>

Andreas Ericsson <ae@op5.se> writes:

> Remove the redundant code from {receive,upload}-pack.c in favour of the
> library code in path.c (previous patch) with documentation of the changes
> to the affected programs.

I like the simplification of these two calling sites, but it makes me feel uneasy to see the workhorse named is_git_repo().

The name implies a check to see if the given path is a git repo or not (i.e. side-effect free predicate), while what it actually does are three things: (1) resolve and check, (2) chdir to it, (3) set up GIT_DIR environment. Not that I have a better name in mind...

> +	SSH Is the default transport protocol and also supports an

Just a typo ("Is")?