Re: [PATCH] speedup allocation in pack-redundant.c
- From
Junio C Hamano <junkio@cox.net>
- Date
- Nov 22, 2005, 20:41 UTC
- Message-ID
- <7vek58ct4b.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <81b0412b0511220656l528436b1xea80ee18965e4dda@mail.gmail.com>
Alex Riesen <raa.lkml@gmail.com> writes:
Show 5 quoted lines
> Subject: [PATCH] speedup allocation in pack-redundant.c > > Reuse discarded nodes of llists > > Signed-off-by: Alex Riesen <ariesen@harmanbecker.com>
I think making allocation/deallocation to the central place is a good cleanup, but I am not sure about the free-nodes reusing. Does this make difference in real life? If so, it might be worth doing the slab-like allocation, since free-nodes are very small structure and malloc overhead is not ignorable there.