git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Beautifulise git-show output

From
Junio C Hamano <junkio@cox.net>
Date
Jul 4, 2006, 22:51 UTC
Message-ID
<7vejx1f0fz.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11520525682686-git-send-email-beber.mailing@gmail.com>
Why?

A patch like this needs to be justified with a bit more explanation; the word "beautiful" is subjective.

(current)
	Change this and that file
        Signed-off-by: A U Thor <a.u.thor@example.com>
	---
         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)
        diff --git a/this-file b/this-file
	...
 
(yours -- and I think 1.3.0 did it like this)
	Change this and that file
        Signed-off-by: A U Thor <a.u.thor@example.com>
	---
         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)
        diff --git a/this-file b/this-file
	...
 
It _might_ be easier to read if it were like this, though:
 
	Change this and that file
        Signed-off-by: A U Thor <a.u.thor@example.com>
	---
         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)
        diff --git a/this-file b/this-file
	...

However, the screen real estate, especially in the vertical direction, is a scarce resource; I do not think the three-dash is a too weak visual separator that needs to be helped by an extra newline.

Previous: beber.mailing@gmail.comNext: Bertrand Jacquin
Message 2 of 3 in “Beautifulise git-show output”
  1. Beautifulise git-show outputbeber.mailing@gmail.com, Jul 4, 2006
  2. Junio C HamanoJul 4, 2006
  3. Bertrand JacquinJul 4, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.