Re: [PATCH] Beautifulise git-show output
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jul 4, 2006, 22:51 UTC
- Message-ID
- <7vejx1f0fz.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <11520525682686-git-send-email-beber.mailing@gmail.com>
Why?
A patch like this needs to be justified with a bit more explanation; the word "beautiful" is subjective.
(current) Change this and that file
Signed-off-by: A U Thor <a.u.thor@example.com>
---
this-file | 20 +++++++----
that-file | 4 ++++
2 files changed, 20 insertions(+), 4 deletions(-)diff --git a/this-file b/this-file ... (yours -- and I think 1.3.0 did it like this) Change this and that file
Signed-off-by: A U Thor <a.u.thor@example.com>
---
this-file | 20 +++++++----
that-file | 4 ++++
2 files changed, 20 insertions(+), 4 deletions(-)diff --git a/this-file b/this-file ... It _might_ be easier to read if it were like this, though: Change this and that file
Signed-off-by: A U Thor <a.u.thor@example.com> ---
this-file | 20 +++++++---- that-file | 4 ++++ 2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/this-file b/this-file ...
However, the screen real estate, especially in the vertical direction, is a scarce resource; I do not think the three-dash is a too weak visual separator that needs to be helped by an extra newline.