Re: [PATCH 2/3] git-fetch: do not use "*" for fetching multiple refs

From: Junio C Hamano <junkio@cox.net>
Date: Dec 6, 2006, 18:37 UTC
Message-ID: <7vejrc50qu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1165429001.993.35.camel@ibook.zvpunry.de>

Michael Loeffler <zvpunry@zvpunry.de> writes:

Show 11 quoted lines

>> Just a thought.
> I would prefer the following ways to do this globfetch stuff:
>
> 1.) The original refspec:
>     Pull: refs/heads/master:refs/remotes/origin/master
>
> 2.) The one with "prefix match":
>     Pull: refs/heads/:refs/remotes/origin/
>
> 3.) The one with extended regex:
>     Pull: refs/heads/(.*):refs/remotes/origin/\1

Please, don't do regex when talking about paths. Uniformly using fnmatch/glob is less confusing. I do not see anything wrong with Andy's refspec glob we already have. Although I agree that the second asterisk in "src/*:dst/*" has a certain "Huh?" factor to UNIX-trained eyes, I think it is quite obvious even to new people what it does.

Also, while I agree that (2) is logical and less typing, I would avoid cases where foo and foo/ behave differently when "foo" itself is a directory/tree like thing. Doing otherwise easily invites mistakes.