Re: [PATCH 1/2] Documentation: Allow @@GIT_VERSION@@ in asciidoc.conf

From: Junio C Hamano <junkio@cox.net>
Date: Mar 23, 2007, 21:53 UTC
Message-ID: <7vejnfpqx5.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11746760451462-git-send-email-frank@lichtenheld.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

Show 14 quoted lines

> Rename asciidoc.conf to asciidoc.conf.in and create
> the former on build time after piping it through sed.
>
> This is useful to allow us to include the git version
> in the documentation.
>
> Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> ---
>  Documentation/Makefile         |   11 ++++++++---
>  Documentation/asciidoc.conf    |   39 ---------------------------------------
>  Documentation/asciidoc.conf.in |   39 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+), 42 deletions(-)
>  delete mode 100644 Documentation/asciidoc.conf
>  create mode 100644 Documentation/asciidoc.conf.in

When sending a patch like this, please use "format-patch -M".

While this is attractive to some degree, *I* am grumpy. Doesn't this patch make html and man branches update all files _every_ time any small change is made to some documentation?