Re: [PATCH] Add sendmail -f support to git-send-email.

From: Junio C Hamano <junkio@cox.net>
Date: Apr 11, 2007, 05:18 UTC
Message-ID: <7vejmrqyj6.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070411003818.GI2813@planck.djpig.de>

Frank Lichtenheld <frank@lichtenheld.de> writes:

Show 8 quoted lines

>> I thought I saw the '-f' patch somewhere on the list in the last
>> several weeks and there was a discussion on this topic that
>> followed the patch.  Am I hallucinating, or was it not applied
>> because there were some issues?
>
> Can't find anything in the archives. So either I completly suck
> at searching, or it is at least several months old, or you
> are hallucinating :)

It was the thread about update-hook that sends e-mail; the discussion ends here:

http://thread.gmane.org/gmane.comp.version-control.git/42927/focus=42996

The patch was from Jim Meyering that made the script to unconditionally pass -f '$envelope_sender'; it was not applied because the whole e-mail sending business was removed from the update hook.

We seem to do a "-f '$envelope_sender'" in the example 'post-receive' hook only when the configuration tells it to, so probably it is a good idea to follow suit in this program.