Re: [PATCH 4/5] Add --remote option to send-pack

From: Junio C Hamano <junkio@cox.net>
Date: Apr 29, 2007, 06:28 UTC
Message-ID: <7vejm3g0dg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0704290152410.28708@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

Show 6 quoted lines

> We're not pretending anything; remote has confirmed that the head that the 
> ref tracks has a particular new value (which we provided), so we should be 
> able to update the tracking ref to that value. I don't think it's 
> particularly important that we came by this information in the course of 
> an exchange that wasn't a fetch.
>

We are indeed pretending.  Consider:

 (1) You push, and push succeeds.

 (2) Somebody fetches your result, works on it and pushes back;
     this might happen in post-receive hook.

 (3) You fetch.  You should see somebody else's commit at the
     tip, not what you pushed in (1).

By not fetching but instead of storing what you pushed, you are pretending that you re-fetched so fast that you gave no chance to anybody to perform (2) quickly enough.

But my conclusion is that this does not matter in practice, and I am agreeing with what you tried to do. That does not change the fact that we are pretending.