git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Move refspec pattern matching to match_refs().

From
Junio C Hamano <junkio@cox.net>
Date
May 26, 2007, 08:20 UTC
Message-ID
<7vejl4m1we.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0705250111200.9778@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 26 quoted lines
> This means that send-pack and http-push will support pattern refspecs,
> so builtin-push.c doesn't have to expand them, and also git push can
> just turn --tags into "refs/tags/*", further simplifying
> builtin-push.c
>
> check_ref_format() gets a third "conditionally okay" result for
> something that's valid as a pattern but not as a particular ref.
>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> ---
> On top of my "remote" series. Shouldn't change any significant behavior, 
> and simplifies a lot of logic. This version takes into account the 
> comments from the previous round (assuming that the ruling on coding style 
> is that:
>
> if (condition)
> 	/* Comment */
> 	statement;
>
> shouldn't have braces).
>
>  builtin-push.c |  133 +++++++++----------------------------------------------
>  refs.c         |   27 ++++++++---
>  remote.c       |   31 ++++++++++++-
>  send-pack.c    |    1 +
>  4 files changed, 70 insertions(+), 122 deletions(-)
Whee.  Removes lots more code than it adds.  Will queue.
Previous: Daniel Barkalow
Message 2 of 2 in “Move refspec pattern matching to match_refs().”
  1. Move refspec pattern matching to match_refs().Daniel Barkalow, May 25, 2007
  2. Junio C HamanoMay 26, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.