Re: [PATCH] Move refspec pattern matching to match_refs().
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 26 quoted lines
> This means that send-pack and http-push will support pattern refspecs,
> so builtin-push.c doesn't have to expand them, and also git push can
> just turn --tags into "refs/tags/*", further simplifying
> builtin-push.c
>
> check_ref_format() gets a third "conditionally okay" result for
> something that's valid as a pattern but not as a particular ref.
>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> ---
> On top of my "remote" series. Shouldn't change any significant behavior,
> and simplifies a lot of logic. This version takes into account the
> comments from the previous round (assuming that the ruling on coding style
> is that:
>
> if (condition)
> /* Comment */
> statement;
>
> shouldn't have braces).
>
> builtin-push.c | 133 +++++++++----------------------------------------------
> refs.c | 27 ++++++++---
> remote.c | 31 ++++++++++++-
> send-pack.c | 1 +
> 4 files changed, 70 insertions(+), 122 deletions(-)
Whee. Removes lots more code than it adds. Will queue.