Re: [PATCH 3/6] git-fsck: Do thorough verification of tag objects.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 6, 2007, 09:03 UTC
- Message-ID
- <7vejkp5ua1.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200706061006.33139.johan@herland.net>
Johan Herland <johan@herland.net> writes:
Show 10 quoted lines
>> This won't practically be problem in newer repositories, but it >> is somewhat annoying. Perhaps do this only under the new -v >> option to git-fsck, say "warning" not "error", and not exit with >> non-zero because of this? > > Like this? > > Or would you rather switch around the "verbose" and the > "parse_and_verify_tag_buffer()" (i.e. not even attempt the thorough > verification unless in verbose mode)?
Actually I was thinking about doing something like this.
- if (parse_and_verify_tag_buffer(0, data, size, 1) && verbose) + if (parse_and_verify_tag_buffer(0, data, size, verbose))