Re: [PATCH] Fix clone to setup the origin if its name ends with .git

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 7, 2007, 02:08 UTC
Message-ID: <7vejkott2b.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070606224906.GB3969@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

> The problem is visible when cloning a local repo. The cloned
> repository will have the origin url setup incorrectly: the origin name
> will be copied verbatim in origin url of the cloned repository.
> Normally, the name is to be expanded into absolute path.

Thanks.

Show 13 quoted lines

> diff --git a/git-clone.sh b/git-clone.sh
> index fdd354f..d45618d 100755
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -20,7 +20,7 @@ usage() {
>  get_repo_base() {
>  	(
>  		cd "`/bin/pwd`" &&
> -		cd "$1" &&
> +		cd "$1" || cd "$1.git" &&
>  		{
>  			cd .git
>  			pwd

We would probably need a to clean up this test a bit, though. When we write our tests, we tend to forget testing the cases where things ought to fail.

I'll probably redo the test myself, but for the record...

 - Please never "unset" GIT_CONFIG.  We do not want the tests to
   get affected with /etc/gitconfig or $HOME/.gitconfig;

 - We would also want to test the cases where a bare repository
   x exists and x.git does not, and try cloning it into y and z
   respectively.  Obviously the former should work and the
   latter should fail.