Re: [PATCH 1/3] Revert changes and extend diff option documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 16, 2007, 19:43 UTC
Message-ID: <7vejdml92c.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1197631424-52586-2-git-send-email-win@wincent.com>

Wincent Colaiuta <win@wincent.com> writes:

Show 16 quoted lines

> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 9ecc1d7..54207f0 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -92,10 +92,10 @@ endif::git-format-patch[]
>  	file gives the default to do so.
>  
>  --check::
> -	Warn if changes introduce trailing whitespace
> -	or an indent that uses a space before a tab. Exits with
> -	non-zero status if problems are found. Not compatible with
> -	--exit-code.
> +	Warn if changes introduce whitespace problems (such as
> +	trailing whitespace). Configuration and per-path attributes
> +	control what git classifies as a whitespace problem (see
> +	gitlink:git-config[1] and gitlink:gitattributes[5]).

This is not quite right, is it? The command still exits with exit code. It is just that the calling process does not see it if you let it spawn the pager.

Show 9 quoted lines

> @@ -197,8 +197,9 @@ endif::git-format-patch[]
>  
>  --exit-code::
>  	Make the program exit with codes similar to diff(1).
> -	That is, it exits with 1 if there were differences and
> -	0 means no differences.
> +	That is, it exits with 0 if there were no differences
> +	and 1 if there were. If --check is used and the
> +	differences introduce whitespace problems exits with 3.

This side is correct.