Re: git-send-email getting filtered as spam by vger.kernel.org

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2008, 21:14 UTC
Message-ID: <7vejb6t3kk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080221205104.GA14247@informatik.uni-freiburg.de>

Uwe Kleine-König  <ukleinek@informatik.uni-freiburg.de> writes:

> Len Brown wrote:
>> It looks like the same patches formatted and set with git 1.5.4.2
>> made it through to the list.
> I suspect 1ca3d6ed01774eab37e96d9c88b840ea618f97af.

When you talk about commits, please also add the summary line, like this [*1*]:

    1ca3d6e (send-email: squelch warning due to comparing undefined $_ to "")

Len said he has the issue with v1.5.4.2-184-gb23b27e but not with v1.5.4.2.

    $ git lg v1.5.4.2..b23b27e -- git-send-email.perl
    1ca3d6e... send-email: squelch warning due to comparing undefined $_ to ""
    6564828... git-send-email: Generalize auto-cc recipient mechanism.
    8a7c56e... git-send-email: Better handling of EOF
    8742997... git-send-email: SIG{TERM,INT} handlers
    2363d74... git-send-email: ssh/login style password requests

and I think you are right. I see In-reply-to: <> in the reject message.

Perhaps we should fix it up like this...

diff --git a/git-send-email.perl b/git-send-email.perl
index ccb87a2..c9f8c6b 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -475,7 +475,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 
 	$initial_reply_to = $_;
 }
-if (defined $initial_reply_to) {
+if (defined $initial_reply_to && $initial_reply_to ne '') {
 	$initial_reply_to =~ s/^\s*<?/</;
 	$initial_reply_to =~ s/>?\s*$/>/;
 }



[Footnote]

*1* Here is what I have in $HOME/.gitconfig to allow me to say
"git one 1ca3d6ed0177".

[alias]
	lg = log --pretty=oneline --abbrev-commit
	one = show -s --pretty='format:%h (%s)'