Re: [PATCH] Windows: set gitexecdir = $(bindir)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2008, 00:32 UTC
Message-ID: <7vej5q67dq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1216366485-12201-5-git-send-email-johannes.sixt@telecom.at>

Johannes Sixt <johannes.sixt@telecom.at> writes:

Show 6 quoted lines

> The "dash-less" change aims to remove git commands from $PATH. It does so
> by defining a GIT_EXEC_PATH that is different from $(bindir). On Windows
> we want a relocatable installation of the git tool, so we cannot use an
> absolute GIT_EXEC_PATH.  Therefore, the implementation of
> builtin_exec_path() on Windows derives the exec-path from the command
> invocation,...

Sorry, I am not sure if I understand what you are trying to solve. If you have ../libexec/git-core/ in GIT_EXEC_PATH (or have builtin_exec_path() use it), then your installation would look like this:

	[[some random place]]
        	bin/git
                libexec/git-core/git-add
                libexec/git-core/git-del
                libexec/git-core/git-dir
                ...

and if "git" can figure out it is "[[some random place]]/bin/git", it can find its subcommands from neighbouring directory, that is still inside the random place the user told the installer to use, can't it?

> This counteracts the aims of the "dash-less" change on Windows, but better
> this way than having no working git at all.

I'd agree to the extent that anything is better than having no working git, but this somewhat feels backwards.