git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: treat -crlf files as binary

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 31, 2008, 16:25 UTC
Message-ID
<7vej45b18y.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<81b0412b0808310216h6c349e1en740a1f4c7fef75e6@mail.gmail.com>
"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 10 quoted lines
> 2008/8/30 Junio C Hamano <gitster@pobox.com>:
>> diff --git i/Documentation/gitattributes.txt w/Documentation/gitattributes.txt
>> ...
>> -       through line endings conversion upon checkin/checkout.
>> +       Unsetting the `crlf` attribute on a path is tells git
>> ...
>
> "+       Unsetting the `crlf` attribute on a path tells git"
>
> (remove "is" before "tells")

Yeah, thanks. I reworded the sentence number of times and somehow crufts were left behind. Fixed, together with the double space before "upon", before committing.

I am actually more surprised by the lack of any surprised comment about the unadvertised presense of "binary" (pseudo)attribute, though. The support has been there since f48fd68 (attribute macro support, 2007-04-14), two days after introduction of gitattributes mechanism.

Maybe somebody should re-read the log message of that commit, and refine the attribute macros sections the patch under discussion has added.

Somebody who can write and spell English better than me, that is ;-)
Previous: Alex RiesenNext: Avery Pennarun
Message 7 of 8 in “diff: treat -crlf files as binary”
  1. diff: treat -crlf files as binaryJunio C Hamano, Aug 29, 2008
  2. Avery PennarunAug 29, 2008
  3. Junio C HamanoAug 30, 2008
  4. Avery PennarunAug 31, 2008
  5. Matthieu MoyAug 31, 2008
  6. Alex RiesenAug 31, 2008
  7. Junio C HamanoAug 31, 2008
  8. Avery PennarunAug 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.