Re: Extra pair of double quotes in "git commit" output?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 25, 2008, 22:02 UTC
- Message-ID
- <7vej0zjwgm.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20081126064906.6117@nanako3.lavabit.com>
Nanako Shiraishi <nanako3@lavabit.com> writes:
Show 9 quoted lines
> While I think the way recent "git commit" displays the commit you just created is very helpful, I often find the double quotes around the message unnecessary and sometimes even confusing. I just made a commit and saw this message: > > [master]: created d9a5491: "Show "standard deviation" column in table 3" > > The colon after the shortened commit SHA1 is enough to signal that it will talk about a different piece of information on the rest of the line. I think the extra double quotes can be dropped safely: > > [master]: created d9a5491: Show "standard deviation" column in table 3 > > and it will make the output shorter by two columns, more pretty, and does not lose the clarity.
[offtopic. Please wrap your text at a reasonable width around 70 columns]
Like this?
It might break some existing tests (I didn't check), but I think that is a sensible thing to do.
builtin-commit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git c/builtin-commit.c w/builtin-commit.c index 591d16b..654bfbe 100644 --- c/builtin-commit.c +++ w/builtin-commit.c @@ -881,7 +881,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1) { struct rev_info rev; struct commit *commit; - static const char *format = "format:%h: \"%s\""; + static const char *format = "format:%h: %s"; unsigned char junk_sha1[20]; const char *head = resolve_ref("HEAD", junk_sha1, 0, NULL);