Re: [PATCH 3/3] gitweb: make gitweb_check_feature a boolean wrapper
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 30, 2008, 00:23 UTC
- Message-ID
- <7vej0uysbs.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <cb7bb73a0811291427n7922ab1fq50caedafe7163f9e@mail.gmail.com>
"Giuseppe Bilotta" <giuseppe.bilotta@gmail.com> writes:
Show 12 quoted lines
> On Sat, Nov 29, 2008 at 10:16 PM, Junio C Hamano <gitster@pobox.com> wrote: >> * Again, this is to demonstrate how I would have liked to see your >> patches as a reviewable series. Notice how this naturally justifies >> the dropping of parentheses in many lines that begin with "my", and >> makes it easier to review? You can review the patch easily by knowing >> that callers that have s/get/check/ are now safe to use scalar context. > > Yes, I get the point: do less things under the hood. I also still > think that three patches with code going ping-pong are way too much, > though 8-P > > For what it's worth, you get my Ack: to your patchset 8-)
Well, I am not interested in taking credits for this series. I am very much interested in reducing my future workload by showing people how an easily reviewable series should look like.
So if you still think it is "way too much", I did not succeed what I tried to do X-<.